This makes the visible/lock/linked/expand buttons more clear that they are indeed buttons. This commit also slightly changes the look of child layers, as they only appear intended and they no longer change color.
A very simple implementation, not as complex as something like #768 yet, but it can be done in the future.
The main current limitation is that it doesn't work with group layers as of right now.
* Initial conversion
* Hide some dialogs
* Update addons
* Fix errors in scripts
Temporarily commented out adding new file import types and certain Control methods that are not available in the Window class, such as get_global_mouse_position()
* Update shaders
* Fix some more errors and signals, rename "pressed" to "button_pressed"
* Even more error fixes and renaming corrections
* Fixed more errors, Pixelorama almost runs
* Update ValueSlider.gd
* Remove lock() and unlock(), more ImageTexture.create_from_image() static usage
* More static function using
* Re-add some of the dialog signals, fix window transparency
* Change instances of popup_hide to visibility_changed
* More more errors and warnings
* Fix more errors and warnings
* Get rid of errors in the output when opening Pixelorama in Godot
* Properly connect most signals without using strings
* Fix some scenes
* Don't load Main.tscn
* Emit signals directly instead of using strings
* Fix Keychain menu nodes
* Get rid of self. on most instances, as setters and getters are now always called
* Some more static typing
* Disable texture filters
* Fix zooming
* Fix int as enum warnings
* Fix tools and rename doubleclick to double_click
* Update tool scenes
* Fix tabs
* Fix create new image
* Use static typing on flood fill to speed it up
* Update static-checks.yml
* Reverts #729 for a speedup, hopefully the bug won't get re-introduced
* Fix TransparentChecker warning
* Re-add Default template
* Fix 3D cels
* Fix rotation
Project converted bug. Should be fixed by https://github.com/godotengine/godot/pull/79264
* Fix UITransparency alignment issue, thanks Variable
* Add missing OptionButton items
Hopefully that should be all of them
* Fix the appearance of CollapsibleContainer
* Change instances of world to world_3d
* Fix tool button backgrounds
* Fix Splash dialog
* Fix brush selection
* Update Main.gd
* Fix About Dialog
* Fix more zooming issues
* Fix canvas preview zooming
* Use signals for queue_redraw on project change
* Fix layer button's look
* Fix gradients
* Some gradient fixes and code cleanups, dithering is still broken
* Fix bucket
* Fix the rest of the undo_redo.add_(un)do_method() cases
* Fix guides
* Fix guide text
* Some small changes in Main
* Update Tools.gd
* Fix palette importing
* Get rid of TODOGODOT4s
* Fix the rest of the dialogs
* Update the rest of the scenes
* Fix onion skinning and frame tag dialogs
* Fix file brushes being imported twice
* Fix palette swatch crashing on double click
* Use nearest filter for some of the windows
* Remove old .tres font files
* Fix language switching
* Get rid of Keychain.action_get_first_key() on the extra shortcuts of tools
* Get rid of Keychain.MenuInputActions and directly set shortcuts to the menu items
This temporarily removes echoing support for undo and redo, this will be re-added once https://github.com/godotengine/godot/pull/36493 or https://github.com/godotengine/godot/pull/64317 is merged.
* Clean shortcut-related duplicate code in TopMenuContainer
* Remove DroidSansFallback now that system fonts can be used as fallback
* Remove 3.x settings from project.godot
* Format
* Format gdgifexporter
* Reset Keychain to its original state
* Remove textures from the dark and gray themes
* Remove all textures from the dark theme
* Better static typing in DrawingAlgos
* Use Vector2i for project size
* [Risky commit] Use Vector2i instead of Vector2 for tools
I tested it and everything seems to be working the same as before, but more testing would be appreciated.
* Format after previous commit
* Fix line angle constraint being rotated 180 degrees
This is not a regression from the previous commit(s), Godot 4 probably reversed the logic of `angle_to_point()`.
* Fix input map action not found errors when pressing Shift or Control
* Make AnimatePanel bigger, add spring interpolation
* Fix some layouts/extensions/preferences loading errors
* Fix dithering
* Update layout resources
Probably doesn't change anything at all, but I suppose it might be a good thing to do
* Small changes
* Disable filter in ResizeCanvas dialog
* Fix some preferences default button states
* Fix tile mode always having masking on
* Use integers in tile mode
* Fix checkboxes in preferences not working
* More statically typed arrays!
No need to have these # Array of X comments anymore!
* Fix "apply all" for multiple preview dialogs
* Update theme.tres
* Add HeaderSmall theme type variation
* Fix dynamics buttons
* Don't allow sub-zero zoom values
* Let zoom_out_max always remain Vector2(0.01, 0.01)
This fixes zooming on large canvases
* Bump version to v1.0-dev
* Fix ambient light not working on 3D cels
* Fix .obj loading
* Don't allow greater than max values in the zoom slider
* Set maximum zoom value to always be (500, 500)
* Set zoom slider minimum value to 1
* Some UI changes, mostly related to buttons and the timeline
* Change window titles to what they were before
* [COMPATIBILITY BROKEN WITH v0.x] Fix loading 3D cels
* Avoid changing Cel3DObject's file_path if it's the same
* Make preferences window bigger
* Fix png exporting
* Fix reference image initial size and filter setting
* Fix perspective line reverse scaling on zoom and facing 180 degrees away from cursor
* Format and some linting
* Remove most Images from the rest of the themes
* Remove all textures from all themes
* Fix drawing when the mouse gets released outside the canvas boundaries
* Format Keychain
* Implement #890
* Fix recorder
* Fix layout deletion
* Better static typing and fix empty_clicked signal-connected methods not having arguments
* Fix layout and extension directory creation if they don't already exist
* Change all instances of "HTML5" to "Web"
OS.get_name() now returns "Web" instead of "HTML5" in Godot 4
* Fix JavaScript detection
Opening files in the Web version does not yet work for some reason
* Fix formatting
* Fix lint errors
* Remove unneeded lines from rotation shaders
* Clean some rotation shader related code
* Remove ErrorManager from #891, as it's no longer needed in Godot 4
* Some docstrings
* More Vector2i and Recti replacing their float counterparts
* Remove the hardcoded shortcut from ValueSlider
Note that the brush size shortcut may not change properly because Keychain isn't updated to support Godot 4's input map properly yet.
* Fix bugs from the rebase, integer zooming is currently broken
* Format
* Fix bug where some imported images would fail to load when using smart slice
* Fix integer zooming (I think)
* Fix errors after #898
* Fix some UI issues with PreviewDialog
* Use ctrl/command instead of just ctrl in the shortcuts of the InputMap - gets rid of the need for _use_osx_shortcuts() in Main.gd
* Update Keychain and addons/README.md
* Update CI to Godot 4.1.1 (probably will not work)
* Remove XDGDataPaths.gd
* Make windows non-exclusive
* Attempt to fix macOS CI
* Attempt to fix CI
* Attempt to fix CI
* Minor fix in the dark theme, more will follow
* Silence enumerator/integer warning
* Attempt to fix macOS CI
* Another attempt to fix macOS CI
* Attempt to fix Windows & macOS CI
* fix: Recorder directory create (#903)
* Update Keychain so that the brush size shortcuts can be changed
This update generally lets users use modifier buttons (control, alt, shift, meta) with mouse buttons
* Change OSX to macOS
* Detect if multi-threading is enabled when exporting gifs
* Fix color picker not working on the top color mode
* Make some public methods private in Export.gd
* Remove Global.window_title variable
* Fix frame UI in the timeline breaking after 100 frames
* Static typing improvements for the timeline
* Better static typing for grids
* Fix typo
* Fix pixel grid not appearing
* Move preference updating code to Global using setters
This should make the code a bit more readable, as the logic for each property update can be found directly under the variable declaration, and not hidden in PreferencesDialog's preference_update() method. This also allows for changing these properties outside the preferences, if that will ever be needed. In theory it's also faster as we don't have to do all these string comparisons anymore, but I doubt this will be noticeable in practice.
* Remove RestoreDefaultButton.tscn
* Implement changing font size in the preferences
* Resize HeaderSmall font size along with the default font size
* A step towards fixing image loading in the Web version
Doesn't completely fix the issue, it requires a fix from Godot's side as well
* Implement missing input event actions for buttons
TODO: Add default shortcuts
* Do not change language and theme if they are already the defaults
Reduces the initial loading time a bit
* Remove update_hint_tooltips() as it's no longer needed, only keep it for tools
This was needed in order for hint tooltips to be successfully translated while taking the shortcuts into account. Godot 4 already it correctly for us now. Tools still need it because they contain multiple shortcut data in their tooltips.
* Change ExportDialog's PathDialog's file mode to be "open directory" and make them bigger
* Fix Vector2i + Vector2 errors in grid center snapping
* Update tooltips when the shortcut profile changes
* Fix copy-paste mistake
* Update tooltips during startup if the shortcut profile is not the default
* Fix gif warning label size in ExportDialog
* Fix BBCode in ExportDialog
* Fix some Godot 4.2 warnings
* Some CI fixes
* Static typing improvements and more inline functions
* Format
* Even more static typing, inline methods, docstrings etc
* Some more static typing improvements and inline setters
* Remove unneeded project type specifying
* Fix splash dialog error
* Fix enumerator warning
* Don't preload the font in the rules and guides
* Fix some integer division warnings
Sometimes we indeed need them to be floats
* Change some Rect2s to Rect2is
* Minor static typing improvements
* Update README, CHANGELOG, Translations
* Only load translation files when needed, reduces loading time a bit
* Update Keychain so it doesn't load languages during startup
* Lazy load all tool scenes, breaks compatibility with the extension API
Decreases initial loading time
* Format
* Very minor loading time speedups
* Remove unneeded project type specifying
* Even more static typing and docstring improvements
* Fix extension loading
* Palette docstrings
---------
Co-authored-by: ppphp <kevinniub@gmail.com>
Revert 21b4f3369f, but make that behavior toggle-able in the Preferences. Also exposes the onion skinning colors for the past and future frames, and renames "Blue-Red Mode" to "Color mode".
Using a signal to change the cel was not a good idea, because it was not being emitted with the undo/redo system. The signal should also fire *after* the cel changes, and this is what happens in this commit. Should be useful for future features and extensions to check whether a cel has been changed.
A small refactor. A very minor performance boost when selecting cels, but also a minor performance decrease when selecting frame buttons. Selecting layer buttons should be pretty much the same. I think the code should be a bit more readable now, plus we got rid of that yield() in Project.gd so that's a bonus.
* Fixed link cel indicator color and animation tags position
* New scrolling and min size
* fixed dockable container for the timeline min size
* Cleanup
* Tweaked minimum size
* Removed some hacks that are no longer needed
* Fixed frame scrollbar not being in the right place at startup, added ensure_control_visible
* frame scroll horziontally without shift if can't scroll vertically + min size tweaks
* Renamed the frames/layer/cel containers
* Always scroll by whole frames
* Fixed conflict
* reoranized AnimationTimeline scene's node tree to wrok as expected
* tweaks
* Fixed tag position and removed uneeded layer button theme code
* added the icon theme code back, I thought this was for the timeline XD
* Smaller LayerButtons
* Save Layer and Cel size between sessions
* Combined _on_AddLayer_pressed and _on_AddGroup_pressed into 1 add_layer method
* Rename scroll container
* formatting
Co-authored-by: MrTriPie <MrTriPie>
* Updated PixelLayerButton's LinkButton's hint_tooltip to be more accurate
* Don't automatically link the current frame's cel when enabling new_cels_linked on a layer
* Mostly added new system
* renamed link group to link set
* Enable drag and drop of linked cels on the same layer
* formatted CelButton.gd
* serialize/deserialize
* Copy frames w/ new linked cels system. Removed copy_cel from layer classes
* Removed commented out code from AnimationTimeline.copy_frames
* Removed Project.duplicate_layers
* Removed unlink_cel in favour of using null with link cel (as the first part of that method was the same)
* Disabled show_behind_parent on PixelCelButton's LinkedIndicator, as it wasn't enough to improve visibility of selection
* Moved BaseLayer.copy out of the Methods to Override section
* Added optional texture param to Cel's set_content method (needed for use when deserializing, and otherwise helpful
* set textures with set_content where needed
* open_image_as_spritesheet_layer new_cels_linked part updated
* clone layer with linked cels implemented. Removed copy_all_cels from layer classes
* weaked how copied layers names are updated
* Merge layers works with new linked cels now
* Fixed texture on cel buttons not being updated on button setup
* fixed bug where using set_content with new image texture would result in an empty texture
* Open old .pxo with new linked cels
* simplified backwards compatiblity
* removed linked_cels
* better linked cels backwards compatibility
* Removed some old TODO comments
* fixed linked_cels conversion bug when linked_cels is empty
* Added undo for linking the previous cel when creating new cels with new_cels_linked enabled
* Removed TODOs
* Cleaned up some method variable naming
* Cleaned up deserialization
* combined matching for loops
* Inlined BaseLayer.copy() where its used
* gdformat
* Fixed Translations,pot
Co-authored-by: MrTriPie <MrTriPie>
* Fixed issues with Shading tool Saturation and Value not always being right in Hue Shading mode
* Shading tool hue shifting fixes and tweaks
* Bringing over changes from layer groups brach, without any changes to layer blending
* Some quick fixes to make it work again
* Fixed some of the places where GroupLayers cause errors. Cel Buttons are now hidden when groups are collapsed
* Layer drag highlighting (need to actually drop them correctly, also need to do cels)
* Added more layer hierarchy related functions, organized the function order in the Layer classes a bit
* Switched the layer type changing from string to int
* Moved layer type enum to Global
* Added get_layer_type_name(), currently used for the default layer name
* Renamed the layer get_children/is_a_parent_of functions
* changed get_layer_type_name() to get_default_name(number)
* New layer drag and dropping behavior
* Added read/write_image_data_from/to_pxo functions to Cel classes to handle saving/loading the binary image data for each cel type
* Fixed warning
* Added a line to child layers wich makes it easier to see where they are in the hierarchy
* Fixed debugger warning
* Fixed all cel types loading as PixelCels
* Fixed spacing issue with cels when collapsing groups
* Fixed bug when dropping a child layer to the bottom region of its parent group, where it would end up to far down (maybe disappearing)
* updated temporary todo comments
* Created a base scene for layer buttons and merged layer button script into one
* Prevent the case of parenting to itself in layer drag and drop, fixed static reference to LayerButton still being BaseLayerButton
* Use a base scene for CelButtons
* First bit of the refactoring work
* Several bits of refactoring
* Fixed moving cels
* Cleaned up Project.move_cel function
* Fixed project_layer_removed
* Updated change_frame_order on FrameButton. Some (not all) work on getting the layer UI updated when pressing buttons such as collapse/visible/lock
* Bug fixes. Updating layer button's buttons
* Fixed timeline selection issues when creating a new project. Some code cleanup
* tweaks
* Removed a bunch of commented out code
* Removing more commented out code
* Fixed bugs with timeline selectio. Fixed cels being placed in the reverse layer order when adding a frame
* Changed add/remove_frame to add/remove_frames (multiple support)
* Refactored copy_frames in animation timeline
* added copy function to cel classes
* added layer copy function
* simplifed copy_frames a tiny bit
* Updated TODO comments to categorize them and remove any that were already done
* Turned Project.add/remove_layer into Project.add/remove_layers (multiple support), not yet tested
* Seperated the layer cloning functionality in timeline's add_layer to its own function, since they're only used by one button, renamed to _on_Button_pressed naming scheme, added children support to the delete layer button
* some TODOs
* Added layer swapping
* Added priorities to refactor TODOs
* Simplified layer swapping code a little
* Fixed performance regression on changing project, updated TODOs
* Included _on_MergeDownLayer_pressed in timeline refactor
* Cleaned up _on_MergeDownLayer_pressed refactor
* If all frames are selected, prevent being able to remove all of them
* Fixed cel linking when cloning layers/frames. Moved the copy function from cel classes to layer classes, splitting into copy_cel and copy_all_cels
* Combined and rewrote the 2 project _toggle_layer_buttons_.. functions into 1 simpler _toggle_layer_buttons function
* Simplified _toggle_layer_buttons some more
* Added hierarchy support for move up/down layer buttons
* Added toggle_frame_buttons method to project (extracted from _frame_changed). Called from main when setting up startup project. Removed _ from start of _toggle_layer_buttons name
* Fixed duplicate_layers parent references being to the original layers
* cleaned up project.move_layers method a bit
* TODOs
* moved the transform_content_confirm calls for the layer buttons in AnimationTimeline (Add/remove/clone) to the project layer modification functions
* animation first/last_frame tweaks and un-press play buttons when the first/last_frame are the same in _on_AnimationTimer_timeout in AnimationTimeline
* Cleaned up project_changed in ANimationTimeline a bit
* Cleaned up project_layer_added in AnimationTimeline
* Changed Layer classes get_default_name to set_name_to_default
* Cleaned up LayerButton.drop_data slightly
* Looked at some of my TODOs
* cleaned up copying cels
* Fixed CelButton linked_indicator not showing up right away when becoming linked
* Cleand up link/unlink cel menu option a little. Fixed situatoin where trying to call button_setup on cel_button that doesn't exist anymore due to undo/redo
* Fixed regression with copy_cel (linked) in when cloning a frame
* Minor cleanup, more detailed comments, updated TODOs
* more improved comments
* Made focus_mode on Cel/Layer/FrameButton NONE to fix bug where it looks like one is selected after pressing it and adding a new Layer/Frame (but its just in the focus state, not the pressed state
* Made AnimationTimeline.change_layer_order work a little more consistantly with LayerButton.drop_data, and fixed a minor bug in it
* Updated comments and TODOs
* cleanup
* removed some code that should no longer be needed
* updated comment
* removed Project's frames and layers setters _frames_changed and _layers_changed
* Made some 'for x in range(array.size())' just 'for x in array.size()'
* updated comments/TODOs
* Cel content changes intial
* Added 'content' methods to Cel classes
* Removed image var from PixelCelButton
* Reusing PixelCelButton.gd on GroupCelButton scene
* Renamed PixelCelButton.gd to CelButton.gd (as it will be used for all Cel Buttons) and deleted GroupCelButton.gd
* Hide the TransparentChecker on GroupCelButton.tscn until a preview texture is added for GroupCels
* TODOs, prevent memory leak when closing projects
* Link/unlink cel cleanup
:
* Added _project param to _init methods of Layer classes
* Added update_texture method to Cel classes (moving part from the update_texture and update_selected_cels_textures methods from Canvas.gd
* Removed a temporary check (which also fixed another bug)
* Clone child layers when cloning a layer
* Added temp dummy get_image method to GroupCel, and use get_image when copying or picking colors
* TODOs
* Made open_image_as_spritesheet_layer work after the timeline refactor (still doesn't work with groups yet though). TODO comment updates
* Added create_new_cel methods to Layer classes
* Updated TODOs and comments
* Renamed Layer class's create_empty_cel to new_empty_cel to match Project's new_emtpy_frame
* Renamed create_layer/cel_button to instantiate_layer/cel_button
* updated TODOs
* prioritized TODOs
* Fixed some warnings
* removed commented out code from previous commit
* Fixed export
* Made open_image_as_new_frame work after timeline refactor
* Fixed open_image_as_new_layer after timeline refactor
* Some linked cel fixes
* More linked cels fixes
* cleanup
* Optimized importing spreadsheet as new layer
* Fixed Scale Image crash with Groups
* Fixed onion skin with groups
* Removed blend_mode from BaseLayer for now
* Mostly fixed image effects
* Fixed resize canvas
* Fixed drag and drop not working with Cel Buttons on Group Layers
* updated TODOs
* Renamed Replace Frame (in open image) to Replace Cel
* Continued renaming Replace Frame to Replace Cel
* Made open_image_at_cels work after timeline refactor
* Added get_layer_path method to BaseLayer
* Replaced AtLayerSpinbox with AtLayerOption for Open Image as New Frame or Replace Cel
* Updated TODOs
* updated TODOs
* Comments for cel content methods
* fixed right clicking group cel button deselecting the button (even though cel is still selected
* frame/layer modification methods comments
* Removed unneeded size flags
* TODO updates
* Removed a loop that would never run from open_image_as_spritesheet_tab
* TODO update
* Combined BaseLayer.get_children_direct and get_children_recursive into a single get_children method with a bool for recursive. Added a get_child_count method
* Removed unneeded frame paramaters from _on_DeleteFrame_pressed and _on_CopyFrame_pressed
* TODO Updates
* Removed unneeded code from delete_frames
* Made delete_frames variable names more consistent with my other changes
* Continuation
* made variable names in copy_frames more consistent with rest of changes
* Update TODOs
* Removed TODOs for after this PR (moved to my notes)
* Fixed crash when pasting image on Group
* Fixed layer .visible check to be is_visible_in_hierarchy()
* Removed some drag highlight polish code that didn't work
* Removed code from Canvas update_texture and update_selected_cels_textures that was redundant
* gdformat
* gdformat
* gdlint fixes
* Fixed Cel button not having its linked indicator show when enabling new cels linked on a layer other than the current layer
* Fixed crop image and centralize image
* Added '# gdlint: ignore=max-public-methods' to the top of Project'
* Fixed dragging cels to layer of different type crash
* Formatted CelButton.gd
Co-authored-by: MrTriPie <MrTriPie>
Removed the "frame_container" property from Layer.gd, which used to hold a reference to a node, leading to orphan nodes being created and never freed. Memory management seems to be working okay now. Previously, every time the user made a change, memory kept going up and never coming down. Now, data that can never be recovered, like undo data that have been rewritten in history, are also removed from memory.
* gdformat .
* Lint code - Part 1
* Format code - Part 2
* Lint code - Part 2
Trying to fix the max allowed line length errors
* Add normal_map_invert_y to the image .import files
Because of Godot 3.4
* Do not call private methods outside of the script's scope
Lint code - Part 3
* Format code - Part 3
* Fixed more line length exceeded errors - Lint code Part 3
* Export array of licenses - Lint code part 4
* Clean hint_tooltip code from Global
Removes a lot of lines of code
* Create static-checks.yml
* Fix FreeType's license
* Fix for multiple cel selection issue
Now it will only apply selection to the selected cels that are **visible and unlocked**
* Fix for loss of selection data
This will hopefully fix the selection data loss on toggling layer buttons
A Project class contains project-specific data like name, undo_redo, frames, layers, tags and brushes. These variables have been moved from Global. This is the first step towards multiple tab support, where each tab will be a different Project.
The Canvas is now single node, instead of having multiple canvases for each frame. This should also be a performance optimization, since there are less canvas nodes, so there are less _input() calls. It should also fix a rare Undo/Redo issue with motion drawing and making lines. Could be unstable, needs more testing.
As a side effect, the guides are now the same for all frames, so this should also close #246.
