huskee/Pixelorama
1
0
Fork 0
mirror of https://github.com/Orama-Interactive/Pixelorama.git synced 2025-01-18 17:19:50 +00:00
Code Issues Wiki Activity

Always display the close button in tabs and let users close projects other than the current

Browse source
This commit is contained in:
Manolis Papadeas 2021-09-01 18:07:36 +03:00
parent fb93143906
commit e4ba665c2a
3 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -39,6 +39,7 @@ Kawan Weege ([@DragonOfWar](https://github.com/DragonOfWar)), Martin Novák ([@n
- The frame delay minimum value is now 0.01 instead of 0. - The frame delay minimum value is now 0.01 instead of 0.
- Cloning frames now create linked cels on layers where the cel linking button is enabled. - Cloning frames now create linked cels on layers where the cel linking button is enabled.
- Window transparency has been temporarily disabled in macOS due to [#491](https://github.com/Orama-Interactive/Pixelorama/issues/491). - Window transparency has been temporarily disabled in macOS due to [#491](https://github.com/Orama-Interactive/Pixelorama/issues/491).
- The close button on tabs is always being displayed, which lets the user close projects other than the current one.
### Fixed ### Fixed
- Issues such as not being able to create guides at random times, which are a result of PoolVectorArray locking issues, may have finally been solved. [#331](https://github.com/Orama-Interactive/Pixelorama/issues/331) - Issues such as not being able to create guides at random times, which are a result of PoolVectorArray locking issues, may have finally been solved. [#331](https://github.com/Orama-Interactive/Pixelorama/issues/331)

5
src/UI/Tabs.gd
View file

@ -6,10 +6,10 @@ func _on_Tabs_tab_changed(tab : int) -> void:
func _on_Tabs_tab_close(tab : int) -> void: func _on_Tabs_tab_close(tab : int) -> void:
if Global.projects.size() == 1 or Global.current_project_index != tab: if Global.projects.size() == 1:
return return
if Global.current_project.has_changed: if Global.projects[tab].has_changed:
if !Global.unsaved_changes_dialog.is_connected("confirmed", self, "delete_tab"): if !Global.unsaved_changes_dialog.is_connected("confirmed", self, "delete_tab"):
Global.unsaved_changes_dialog.connect("confirmed", self, "delete_tab", [tab]) Global.unsaved_changes_dialog.connect("confirmed", self, "delete_tab", [tab])
Global.unsaved_changes_dialog.popup_centered() Global.unsaved_changes_dialog.popup_centered()
@ -39,6 +39,7 @@ func delete_tab(tab : int) -> void:
OpenSave.current_save_paths.remove(tab) OpenSave.current_save_paths.remove(tab)
OpenSave.backup_save_paths.remove(tab) OpenSave.backup_save_paths.remove(tab)
Global.projects.remove(tab) Global.projects.remove(tab)
if Global.current_project_index == tab:
if tab > 0: if tab > 0:
Global.current_project_index -= 1 Global.current_project_index -= 1
else: else:

2
src/UI/UI.tscn
View file

@ -1076,7 +1076,7 @@ margin_top = 7.0
margin_right = 889.0 margin_right = 889.0
margin_bottom = 31.0 margin_bottom = 31.0
tab_align = 0 tab_align = 0
tab_close_display_policy = 1 tab_close_display_policy = 2
drag_to_rearrange_enabled = true drag_to_rearrange_enabled = true
script = ExtResource( 3 ) script = ExtResource( 3 )