huskee/Pixelorama
1
0
Fork 0
mirror of https://github.com/Orama-Interactive/Pixelorama.git synced 2025-02-20 12:33:14 +00:00
Code Issues Wiki Activity

Api Improvements (#802)

Browse source 
* Api Improvements

Proper Removal of Tools
A new `get_current_cel_info()` method

* a new show_error() method

usefull for displaying messages like "Incompatible API" etc...

* typo

* formatting

* added an improvement
This commit is contained in:
Variable 2023-01-04 19:21:15 +05:00 • committed by GitHub
parent ee8d321902
commit d7e33f4431
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/Autoload/ExtensionsAPI.gd
View file

@ -4,6 +4,13 @@ extends Node
enum { FILE, EDIT, SELECT, IMAGE, VIEW, WINDOW, HELP }
func show_error(text: String) -> void:
# useful for displaying messages like "Incompatible API" etc...
Global.error_dialog.set_text(text)
Global.error_dialog.popup_centered()
Global.dialog_open(true)
func get_api_version() -> int:
return ProjectSettings.get_setting("application/config/ExtensionsAPI_Version")
@ -20,6 +27,22 @@ func get_current_project() -> Project:
return Global.current_project
func get_current_cel_info() -> Dictionary:
# As types of cel are added to Pixelorama,
# then the old extension would have no idea how to identify the types they use
# E.g the extension may try to use a GroupCel as a PixelCel (if it doesn't know the difference)
# So it's encouraged to use this function to access cels
var project = get_current_project()
var cel = project.get_current_cel()
# Add cel types as we have more and more cels
if cel is PixelCel:
return {"cel": cel, "type": "PixelCel"}
elif cel is GroupCel:
return {"cel": cel, "type": "GroupCel"}
else:
return {"cel": cel, "type": "BaseCel"}
func get_global() -> Global:
return Global
@ -160,7 +183,6 @@ func add_menu_item(menu_type: int, item_name: String, item_metadata, item_id :=
if item_id == -1:
idx = popup_menu.get_item_count() - 1
popup_menu.set_item_metadata(idx, item_metadata)
return idx
@ -188,6 +210,9 @@ func add_tool(
func remove_tool(tool_name: String) -> void:
# Re-assigning the tools in case the tool to be removed is also Active
Tools.assign_tool("Pencil", BUTTON_LEFT)
Tools.assign_tool("Eraser", BUTTON_RIGHT)
var tool_class: Tools.Tool = Tools.tools[tool_name]
if tool_class:
Tools.remove_tool(tool_class)