huskee/Pixelorama
1
0
Fork 0
mirror of https://github.com/Orama-Interactive/Pixelorama.git synced 2025-01-18 09:09:47 +00:00
Code Issues Wiki Activity

Remove Renderer from the Preferences

Browse source 
Not currently needed, as it's not possible to change between OpenGL and Vulkan drivers. We could implement this is https://github.com/godotengine/godot/issues/80565 is fixed.
This commit is contained in:
Emmanouil Papadeas 2024-06-14 17:00:26 +03:00
parent fc10d600a5
commit bc26557219
3 changed files with 7 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/Autoload/Global.gd
View file

@ -497,9 +497,6 @@ var enable_autosave := true:
return
enable_autosave = value
OpenSave.update_autosave()
## Found in Preferences. The index of graphics renderer used by Pixelorama.
var renderer := 0:
set = _renderer_changed
## Found in Preferences. The index of tablet driver used by Pixelorama.
var tablet_driver := 0:
set(value):
@ -947,21 +944,6 @@ func undo_or_redo(
project.has_changed = true
func _renderer_changed(value: int) -> void:
renderer = value
# if OS.has_feature("editor"):
# return
#
# # Sets GLES2 as the default value in `override.cfg`.
# # Without this, switching to GLES3 does not work, because it will default to GLES2.
# ProjectSettings.set_initial_value("rendering/quality/driver/driver_name", "GLES2")
# var renderer_name := OS.get_video_driver_name(renderer)
# ProjectSettings.set_setting("rendering/quality/driver/driver_name", renderer_name)
# ProjectSettings.save_custom(root_directory.path_join(OVERRIDE_FILE))
## Use this to prepare Pixelorama before opening a dialog.
func dialog_open(open: bool, is_file_dialog := false) -> void:
if is_file_dialog and use_native_file_dialogs:

13
src/Preferences/PreferencesDialog.gd
View file

@ -182,9 +182,6 @@ var preferences: Array[Preference] = [
false,
true
),
# Preference.new(
# "renderer", "Drivers/DriversContainer/Renderer", "selected", OS.VIDEO_DRIVER_GLES2, true
# ),
Preference.new("tablet_driver", "Drivers/DriversContainer/TabletDriver", "selected", 0)
]
@ -243,17 +240,21 @@ func _ready() -> void:
child.confirmed.connect(Tools.update_hint_tooltips)
if OS.get_name() == "Web":
var startup := right_side.get_node("Startup")
var startup := right_side.get_node(^"Startup")
right_side.remove_child(startup)
startup.queue_free()
right_side.get_node("Language").visible = true
right_side.get_node(^"Language").visible = true
Global.open_last_project = false
elif OS.get_name() == "Windows":
if OS.get_name() == "Windows":
tablet_driver_label.visible = true
tablet_driver.visible = true
for driver in DisplayServer.tablet_get_driver_count():
var driver_name := DisplayServer.tablet_get_driver_name(driver)
tablet_driver.add_item(driver_name, driver)
else:
var drivers := right_side.get_node(^"Drivers")
right_side.remove_child(drivers)
drivers.queue_free()
if not OS.has_feature("pc"):
get_tree().call_group(&"DesktopOnly", &"queue_free")

19
src/Preferences/PreferencesDialog.tscn
View file

@ -1091,25 +1091,6 @@ size_flags_horizontal = 3
layout_mode = 2
columns = 3
[node name="RendererLabel" type="Label" parent="HSplitContainer/VBoxContainer/ScrollContainer/RightSide/Drivers/DriversContainer"]
layout_mode = 2
size_flags_horizontal = 3
mouse_filter = 0
text = "Renderer:"
[node name="Renderer" type="OptionButton" parent="HSplitContainer/VBoxContainer/ScrollContainer/RightSide/Drivers/DriversContainer"]
layout_mode = 2
size_flags_horizontal = 3
tooltip_text = "Specifies the renderer/video driver being used. GLES2 is better for older and low-end devices, but GLES3 may offer more features."
mouse_default_cursor_shape = 2
disabled = true
item_count = 2
selected = 0
popup/item_0/text = "OpenGL"
popup/item_0/id = 0
popup/item_1/text = "Vulkan"
popup/item_1/id = 1
[node name="TabletDriverLabel" type="Label" parent="HSplitContainer/VBoxContainer/ScrollContainer/RightSide/Drivers/DriversContainer"]
unique_name_in_owner = true
visible = false