Refactor SplashDialog.gd to make a class for the artworks, update the version text in the splash screen

src/UI/Dialogs/SplashDialog.gd

@@ -1,81 +1,98 @@
 extends AcceptDialog
 
-var artworks := [
+var artworks: Array[Artwork] = [
-	[  # Licensed under CC-BY-NC-ND, https://creativecommons.org/licenses/by-nc-nd/4.0/
+	Artwork.new(
-		"Roroto Sic",
 		preload("res://assets/graphics/splash_screen/artworks/roroto.png"),
+		"Roroto Sic",
 		"https://linktr.ee/Roroto_Sic",
-		Color.WHITE
+		Color.WHITE,
-	],
+		"Licensed under CC-BY-NC-ND, https://creativecommons.org/licenses/by-nc-nd/4.0/"
-	[  # Licensed under CC BY-NC-SA 4.0, https://creativecommons.org/licenses/by-nc-sa/4.0/
+	),
-		"Exuvita",
+	Artwork.new(
 		preload("res://assets/graphics/splash_screen/artworks/exuvita.png"),
+		"Exuvita",
 		"",
-		Color.BLACK
+		Color.BLACK,
-	],
+		"Licensed under CC BY-NC-SA 4.0, https://creativecommons.org/licenses/by-nc-sa/4.0/"
-	[  # Licensed under CC BY-NC-SA 4.0, https://creativecommons.org/licenses/by-nc-sa/4.0/
+	),
-		"Uch",
+	Artwork.new(
 		preload("res://assets/graphics/splash_screen/artworks/uch.png"),
+		"Uch",
 		"https://www.instagram.com/vs.pxl/",
-		Color.BLACK
+		Color.BLACK,
-	],
+		"Licensed under CC BY-NC-SA 4.0, https://creativecommons.org/licenses/by-nc-sa/4.0/"
-	[  # Licensed under CC BY-NC-SA 4.0, https://creativecommons.org/licenses/by-nc-sa/4.0/
+	),
-		"Wishdream",
+	Artwork.new(
 		preload("res://assets/graphics/splash_screen/artworks/wishdream.png"),
+		"Wishdream",
 		"https://twitter.com/WishdreamStar",
-		Color.BLACK
+		Color.BLACK,
-	],
+		"Licensed under CC BY-NC-SA 4.0, https://creativecommons.org/licenses/by-nc-sa/4.0/"
+	),
 ]
 
 var chosen_artwork: int
 @onready var art_by_label := %ArtistName as Button
 @onready var splash_art_texturerect := %SplashArt as TextureRect
 @onready var version_text := %VersionText as TextureRect
+@onready var show_on_startup := %ShowOnStartup as CheckBox
+
+
+class Artwork:
+	var artwork: Texture2D
+	var artist_name := ""
+	var artist_link := ""
+	var text_modulation: Color
+	var license_information := ""
+
+	func _init(
+		_artwork: Texture2D,
+		_artist_name := "",
+		_artist_link := "",
+		_text_modulation := Color.WHITE,
+		_license_information := ""
+	) -> void:
+		artwork = _artwork
+		artist_name = _artist_name
+		artist_link = _artist_link
+		text_modulation = _text_modulation
+		license_information = _license_information
 
 
 func _ready() -> void:
 	get_ok_button().visible = false
-
-
-func _on_SplashDialog_about_to_show() -> void:
-	var show_on_startup_button: CheckBox = find_child("ShowOnStartup")
-	if Global.config_cache.has_section_key("preferences", "startup"):
-		show_on_startup_button.button_pressed = !Global.config_cache.get_value(
-			"preferences", "startup"
-		)
-	title = "Pixelorama" + " " + Global.current_version
-
-	chosen_artwork = randi() % artworks.size()
-	change_artwork(0)
-
 	if OS.get_name() == "Web":
 		$Contents/ButtonsPatronsLogos/Buttons/OpenLastBtn.visible = false
 
 
-func change_artwork(direction: int) -> void:
+func _on_SplashDialog_about_to_show() -> void:
-	if chosen_artwork + direction > artworks.size() - 1 or chosen_artwork + direction < 0:
+	if Global.config_cache.has_section_key("preferences", "startup"):
-		chosen_artwork = 0 if direction == 1 else artworks.size() - 1
+		show_on_startup.button_pressed = not Global.config_cache.get_value("preferences", "startup")
+	title = "Pixelorama" + " " + Global.current_version
+
+	if not artworks.is_empty():
+		chosen_artwork = randi() % artworks.size()
+		change_artwork(0)
 	else:
-		chosen_artwork = chosen_artwork + direction
+		$Contents/SplashArt/ChangeArtBtnLeft.visible = false
+		$Contents/SplashArt/ChangeArtBtnRight.visible = false
 
-	splash_art_texturerect.texture = artworks[chosen_artwork][1]
 
-	art_by_label.text = tr("Art by: %s") % artworks[chosen_artwork][0]
+func change_artwork(direction: int) -> void:
-	art_by_label.tooltip_text = artworks[chosen_artwork][2]
+	chosen_artwork = wrapi(chosen_artwork + direction, 0, artworks.size())
-
+	splash_art_texturerect.texture = artworks[chosen_artwork].artwork
-	version_text.modulate = artworks[chosen_artwork][3]
+	art_by_label.text = tr("Art by: %s") % artworks[chosen_artwork].artist_name
+	art_by_label.tooltip_text = artworks[chosen_artwork].artist_link
+	version_text.modulate = artworks[chosen_artwork].text_modulation
 
 
 func _on_ArtCredits_pressed() -> void:
-	if artworks[chosen_artwork][2]:
+	if not artworks[chosen_artwork].artist_link.is_empty():
-		OS.shell_open(artworks[chosen_artwork][2])
+		OS.shell_open(artworks[chosen_artwork].artist_link)
 
 
 func _on_ShowOnStartup_toggled(pressed: bool) -> void:
-	if pressed:
+	Global.config_cache.set_value("preferences", "startup", not pressed)
-		Global.config_cache.set_value("preferences", "startup", false)
-	else:
-		Global.config_cache.set_value("preferences", "startup", true)
 	Global.config_cache.save(Global.CONFIG_PATH)
 
 

src/UI/Dialogs/SplashDialog.tscn

@@ -1,7 +1,6 @@
-[gd_scene load_steps=14 format=3 uid="uid://bnpb1aip3wdvw"]
+[gd_scene load_steps=13 format=3 uid="uid://bnpb1aip3wdvw"]
 
 [ext_resource type="Script" path="res://src/UI/Dialogs/SplashDialog.gd" id="1"]
-[ext_resource type="Texture2D" uid="uid://b5adjms3vxj13" path="res://assets/graphics/splash_screen/artworks/wishdream.png" id="2"]
 [ext_resource type="Texture2D" uid="uid://d1oxrkwndy5fi" path="res://assets/graphics/timeline/move_arrow.png" id="3"]
 [ext_resource type="Texture2D" uid="uid://b47r0c6auaqk6" path="res://assets/graphics/icons/icon.png" id="4"]
 [ext_resource type="Texture2D" uid="uid://dywk5yd41twch" path="res://assets/graphics/splash_screen/version.png" id="5"]
@@ -46,7 +45,6 @@ theme_override_constants/separation = 8
 unique_name_in_owner = true
 layout_mode = 2
 size_flags_vertical = 3
-texture = ExtResource("2")
 expand_mode = 1
 stretch_mode = 5
 
@@ -128,7 +126,7 @@ custom_minimum_size = Vector2(84, 12)
 layout_mode = 2
 size_flags_vertical = 4
 texture = ExtResource("5")
-expand_mode = 1
+stretch_mode = 4
 
 [node name="ArtBy" type="HBoxContainer" parent="Contents"]
 layout_mode = 2
@@ -252,6 +250,7 @@ theme_override_constants/separation = 0
 alignment = 2
 
 [node name="ShowOnStartup" type="CheckBox" parent="Contents/CopyrightLabel/HBoxContainer"]
+unique_name_in_owner = true
 layout_mode = 2
 size_flags_vertical = 0
 mouse_default_cursor_shape = 2