huskee/Pixelorama
1
0
Fork 0
mirror of https://github.com/Orama-Interactive/Pixelorama.git synced 2025-02-21 13:03:13 +00:00
Code Issues Wiki Activity

Minor TransparentChecker performance boost

Browse source 
Got rid of its _process, using _ready() instead. It also gets called when the canvas size changes, or the checker settings in the preferences change.
This commit is contained in:
OverloadedOrama 2020-04-20 19:12:22 +03:00
parent b21455cfd0
commit 79a4c0232e
4 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Scripts/Canvas.gd
View file

@ -531,6 +531,8 @@ func camera_zoom() -> void:
Global.horizontal_ruler.update() Global.horizontal_ruler.update()
Global.vertical_ruler.update() Global.vertical_ruler.update()
Global.transparent_checker._ready() # To update the rect size
func handle_undo(action : String) -> void: func handle_undo(action : String) -> void:
if !can_undo: if !can_undo:
return return

5
Scripts/Dialogs/PreferencesDialog.gd
View file

@ -97,6 +97,8 @@ func _ready() -> void:
Global.checker_color_2 = Global.config_cache.get_value("preferences", "checker_color_2") Global.checker_color_2 = Global.config_cache.get_value("preferences", "checker_color_2")
checker_color_2.color = Global.checker_color_2 checker_color_2.color = Global.checker_color_2
Global.transparent_checker._ready()
if Global.config_cache.has_section_key("preferences", "guide_color"): if Global.config_cache.has_section_key("preferences", "guide_color"):
Global.guide_color = Global.config_cache.get_value("preferences", "guide_color") Global.guide_color = Global.config_cache.get_value("preferences", "guide_color")
for canvas in Global.canvases: for canvas in Global.canvases:
@ -405,18 +407,21 @@ func _on_GridColor_color_changed(color : Color) -> void:
func _on_CheckerSize_value_changed(value : float) -> void: func _on_CheckerSize_value_changed(value : float) -> void:
Global.checker_size = value Global.checker_size = value
Global.transparent_checker._ready()
Global.config_cache.set_value("preferences", "checker_size", value) Global.config_cache.set_value("preferences", "checker_size", value)
Global.config_cache.save("user://cache.ini") Global.config_cache.save("user://cache.ini")
func _on_CheckerColor1_color_changed(color : Color) -> void: func _on_CheckerColor1_color_changed(color : Color) -> void:
Global.checker_color_1 = color Global.checker_color_1 = color
Global.transparent_checker._ready()
Global.config_cache.set_value("preferences", "checker_color_1", color) Global.config_cache.set_value("preferences", "checker_color_1", color)
Global.config_cache.save("user://cache.ini") Global.config_cache.save("user://cache.ini")
func _on_CheckerColor2_color_changed(color : Color) -> void: func _on_CheckerColor2_color_changed(color : Color) -> void:
Global.checker_color_2 = color Global.checker_color_2 = color
Global.transparent_checker._ready()
Global.config_cache.set_value("preferences", "checker_color_2", color) Global.config_cache.set_value("preferences", "checker_color_2", color)
Global.config_cache.save("user://cache.ini") Global.config_cache.save("user://cache.ini")

2
Scripts/Global.gd
View file

@ -199,6 +199,7 @@ var camera_preview : Camera2D
var selection_rectangle : Polygon2D var selection_rectangle : Polygon2D
var horizontal_ruler : BaseButton var horizontal_ruler : BaseButton
var vertical_ruler : BaseButton var vertical_ruler : BaseButton
var transparent_checker : ColorRect
var file_menu : MenuButton var file_menu : MenuButton
var edit_menu : MenuButton var edit_menu : MenuButton
@ -324,6 +325,7 @@ func _ready() -> void:
selection_rectangle = find_node_by_name(root, "SelectionRectangle") selection_rectangle = find_node_by_name(root, "SelectionRectangle")
horizontal_ruler = find_node_by_name(root, "HorizontalRuler") horizontal_ruler = find_node_by_name(root, "HorizontalRuler")
vertical_ruler = find_node_by_name(root, "VerticalRuler") vertical_ruler = find_node_by_name(root, "VerticalRuler")
transparent_checker = find_node_by_name(root, "TransparentChecker")
file_menu = find_node_by_name(root, "FileMenu") file_menu = find_node_by_name(root, "FileMenu")
edit_menu = find_node_by_name(root, "EditMenu") edit_menu = find_node_by_name(root, "EditMenu")

3
Scripts/TransparentChecker.gd
View file

@ -1,6 +1,7 @@
extends ColorRect extends ColorRect
func _process(_delta):
func _ready():
rect_size = Global.canvas.size rect_size = Global.canvas.size
material.set_shader_param("size", Global.checker_size) material.set_shader_param("size", Global.checker_size)
material.set_shader_param("color1", Global.checker_color_1) material.set_shader_param("color1", Global.checker_color_1)