huskee/Pixelorama
1
0
Fork 0
mirror of https://github.com/Orama-Interactive/Pixelorama.git synced 2025-02-08 19:39:50 +00:00
Code Issues Wiki Activity
Pixelorama/src/UI/Timeline/FrameProperties.gd

30 lines
1.1 KiB
GDScript3
Raw Normal View History

Frame properties (#357) * Sync for my local files to my repository * This is frame properties update, it works but I can't be stored while saving or loading and that makes crashes just the beggining :) * I forgot this files :P * Frame Properties update. * Updating frame properties * Update Translations.pot * Changes to CanvasPreview and CelButton change
2020-10-19 14:57:40 +00:00
extends ConfirmationDialog
onready var frame_num = $VBoxContainer/GridContainer/FrameNum
onready var frame_dur = $VBoxContainer/GridContainer/FrameTime
func set_frame_label(frame : int) -> void:
frame_num.set_text(str(frame + 1))
func set_frame_dur(duration : float) -> void:
Added Turkish translation
2020-12-10 18:39:29 +00:00
frame_dur.set_value(duration)
Frame properties (#357) * Sync for my local files to my repository * This is frame properties update, it works but I can't be stored while saving or loading and that makes crashes just the beggining :) * I forgot this files :P * Frame Properties update. * Updating frame properties * Update Translations.pot * Changes to CanvasPreview and CelButton change
2020-10-19 14:57:40 +00:00
func _on_FrameProperties_popup_hide() -> void:
Global.dialog_open(false)
func _on_FrameProperties_confirmed():
Put frame duration as a member of the Frame class Instead of having a frame_duration[] array in the Project class. This makes the code much more readable and understandable, using less lines of code and, by avoiding an extra array, we also avoid potential out-of-bound array crashes. The functionality for the user has not changed, and by testing so far I didn't find any issues.
2020-12-16 20:54:08 +00:00
var frame : int = int(frame_num.get_text()) - 1
Frame properties (#357) * Sync for my local files to my repository * This is frame properties update, it works but I can't be stored while saving or loading and that makes crashes just the beggining :) * I forgot this files :P * Frame Properties update. * Updating frame properties * Update Translations.pot * Changes to CanvasPreview and CelButton change
2020-10-19 14:57:40 +00:00
var duration : float = frame_dur.get_value()
Put frame duration as a member of the Frame class Instead of having a frame_duration[] array in the Project class. This makes the code much more readable and understandable, using less lines of code and, by avoiding an extra array, we also avoid potential out-of-bound array crashes. The functionality for the user has not changed, and by testing so far I didn't find any issues.
2020-12-16 20:54:08 +00:00
var new_duration = Global.current_project.frames[frame].duration
new_duration = duration
Frame properties (#357) * Sync for my local files to my repository * This is frame properties update, it works but I can't be stored while saving or loading and that makes crashes just the beggining :) * I forgot this files :P * Frame Properties update. * Updating frame properties * Update Translations.pot * Changes to CanvasPreview and CelButton change
2020-10-19 14:57:40 +00:00
Global.current_project.undos += 1
Global.current_project.undo_redo.create_action("Change frame duration")
Put frame duration as a member of the Frame class Instead of having a frame_duration[] array in the Project class. This makes the code much more readable and understandable, using less lines of code and, by avoiding an extra array, we also avoid potential out-of-bound array crashes. The functionality for the user has not changed, and by testing so far I didn't find any issues.
2020-12-16 20:54:08 +00:00
Global.current_project.undo_redo.add_do_property(Global.current_project.frames[frame], "duration", new_duration)
Global.current_project.undo_redo.add_undo_property(Global.current_project.frames[frame], "duration", Global.current_project.frames[frame].duration)
Frame properties (#357) * Sync for my local files to my repository * This is frame properties update, it works but I can't be stored while saving or loading and that makes crashes just the beggining :) * I forgot this files :P * Frame Properties update. * Updating frame properties * Update Translations.pot * Changes to CanvasPreview and CelButton change
2020-10-19 14:57:40 +00:00
Global.current_project.undo_redo.add_do_method(Global, "redo")
Global.current_project.undo_redo.add_undo_method(Global, "undo")
Global.current_project.undo_redo.commit_action()
Copy permalink